From f8ad1dd7aa0eb57d811231c850effb64ca23ca64 Mon Sep 17 00:00:00 2001
From: Reza Behzadan <rbehzadan@gmail.com>
Date: Tue, 6 Feb 2024 08:13:49 +0330
Subject: [PATCH] Fix: updater doesn't leave behind unwanted folders anymore

---
 geoip_updater.sh | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/geoip_updater.sh b/geoip_updater.sh
index 9befc8e..84d4c89 100755
--- a/geoip_updater.sh
+++ b/geoip_updater.sh
@@ -61,13 +61,19 @@ download_geoip_package() {
 
 # Extract the MMDB file from the downloaded package
 extract_mmdb() {
-  MMDB_PATH=$(tar -tzf "/tmp/${FN}" | grep "${MMDB}" || true)
+  # Ensure extraction occurs in a temporary directory to avoid leaving behind unwanted folders
+  pushd /tmp >/dev/null
+  MMDB_PATH=$(tar -tzf "${FN}" | grep "${MMDB}" || true)
   if [ -n "$MMDB_PATH" ]; then
-    tar -xzf "/tmp/${FN}" "${MMDB_PATH}" && mv "$MMDB_PATH" $DEST
+    tar -xzf "${FN}" "${MMDB_PATH}" && mv "${MMDB_PATH}" "$DEST"
   else
     echo "Failed to find ${MMDB} in the tarball." >&2
+    popd >/dev/null
     exit 1
   fi
+  # Cleanup the temporary directory by removing any extracted directories
+  rm -rf "$(dirname "${MMDB_PATH}")"
+  popd >/dev/null
 }
 
 # Clean up the temporary files